Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bind DOCKER_OPTS option #2718

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Fix bind DOCKER_OPTS option #2718

merged 2 commits into from
Oct 25, 2024
+3 −4

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Oct 24, 2024 •
edited
Loading

Description

SSIA

Related Issue

Versions

  • Vald Version: v1.7.13
  • Go Version: v1.23.2
  • Rust Version: v1.81.0
  • Docker Version: v27.3.1
  • Kubernetes Version: v1.31.1
  • Helm Version: v3.16.2
  • NGT Version: v2.2.4
  • Faiss Version: v1.9.0

Checklist

Special notes for your reviewer

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2024

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (3)
  • WIP
  • DO NOT MERGE
  • DNM

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

kpango
kpango previously approved these changes Oct 25, 2024
View reviewed changes
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 25, 2024 •
edited
Loading

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9b2dfdb
Status: ✅  Deploy successful!
Preview URL: https://de9cd8e0.vald.pages.dev
Branch Preview URL: https://ci-makefile-fix-docker-opts.vald.pages.dev

View logs

@vankichi vankichi changed the title [WIP] Fix bind DOCKER_OPTS option Fix bind DOCKER_OPTS option Oct 25, 2024
@kpango kpango requested a review from kmrmt October 25, 2024 02:58
@kmrmt kmrmt merged commit f0fd747 into main Oct 25, 2024
149 checks passed
@kmrmt kmrmt deleted the ci/makefile/fix-docker-opts-bind branch October 25, 2024 04:29
vankichi added a commit that referenced this pull request Oct 25, 2024
@vankichi
Fix bind DOCKER_OPTS option (#2718)
6463143 
* 🐛 Fix bind DOCKER_OPTS option

Signed-off-by: vankichi <[email protected]>

* Fix

---------

Signed-off-by: vankichi <[email protected]>
kpango pushed a commit that referenced this pull request Oct 25, 2024
@vankichi
Backport PR #2718 to release/v1.7 for Fix bind DOCKER_OPTS option (#2719
1dd771f 
)

* Fix bind DOCKER_OPTS option (#2718)

* 🐛 Fix bind DOCKER_OPTS option

Signed-off-by: vankichi <[email protected]>

* Fix

---------

Signed-off-by: vankichi <[email protected]>

* Apply suggestions from code review

Signed-off-by: Kiichiro YUKAWA <[email protected]>

---------

Signed-off-by: vankichi <[email protected]>
Signed-off-by: Kiichiro YUKAWA <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Closed
takuyaymd pushed a commit to takuyaymd/vald that referenced this pull request Dec 2, 2024
@vankichi @takuyaymd
Fix bind DOCKER_OPTS option (vdaas#2718)
dd5ebc6 
* 🐛 Fix bind DOCKER_OPTS option

Signed-off-by: vankichi <[email protected]>

* Fix

---------

Signed-off-by: vankichi <[email protected]>
takuyaymd pushed a commit to takuyaymd/vald that referenced this pull request Dec 2, 2024
@vankichi @takuyaymd
Fix bind DOCKER_OPTS option (vdaas#2718)
6d3c6cf 
* 🐛 Fix bind DOCKER_OPTS option

Signed-off-by: vankichi <[email protected]>

* Fix

---------

Signed-off-by: vankichi <[email protected]>
This was referenced Dec 3, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpango kpango kpango approved these changes

@kmrmt kmrmt kmrmt approved these changes

Assignees
No one assigned
Labels
area/makefile priority/low size/S type/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vankichi @vdaas-ci @kmrmt @kpango